Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Past behavior of the
init_send_tx
method with InitSendTxArgs (only when the recipient wallet was reachable):finalise
iff InitSendTxArgs containsfinalize=true
and returns the final slatepost_tx
iff InitSendTxArgs containspost_tx=true
and returns the final slateCurrent behavior with the same condition:
post_tx=true
Sender lock outputs, finalize and post_tx iffpost_tx=true
and returns the final slatepost_tx=false
Sender returns the first slateThis PR locks outputs, finalise and return the final transaction but do not post when
post_tx=false
.Fixes #480.
Might not be the best solution though. Thoughts @yeastplume ?