Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix arrow go client #35819

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: Fix arrow go client #35819

merged 1 commit into from
Aug 29, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #35662

@bigsheeper
fix: Fix arrow go client
32cfb01 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Aug 29, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Aug 29, 2024
@bigsheeper bigsheeper mentioned this pull request Aug 29, 2024
Merged
@czs007
Copy link
Collaborator

czs007 commented Aug 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Aug 29, 2024
@bigsheeper
fix: Fix arrow go client (#35819) (#35820)
a1d3932 
issue: #35662

pr: #35819

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot added the ci-passed label Aug 29, 2024
@sre-ci-robot sre-ci-robot merged commit 6926597 into milvus-io:master Aug 29, 2024
14 checks passed
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (0e7877d) to head (32cfb01).
Report is 35 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35819      +/-   ##
==========================================
+ Coverage   72.37%   72.45%   +0.08%     
==========================================
  Files        1237     1252      +15     
  Lines      147726   149245    +1519     
==========================================
+ Hits       106912   108133    +1221     
- Misses      36054    36260     +206     
- Partials     4760     4852      +92

see 163 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @czs007 @sre-ci-robot