Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Retry on inconsistent requery result (#31713) #31734

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

bigsheeper
Copy link
Contributor

Make retry on ErrInConsistentRequery in proxy rather than in every SDK.

issue: #31642

pr: #31713

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 29, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 80.61%. Comparing base (ef267b5) to head (8b43030).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31734      +/-   ##
==========================================
+ Coverage   80.49%   80.61%   +0.11%     
==========================================
  Files         974      974              
  Lines      137892   138840     +948     
==========================================
+ Hits       110998   111921     +923     
- Misses      23177    23183       +6     
- Partials     3717     3736      +19     
Files Coverage Δ
internal/proxy/impl.go 86.04% <70.00%> (-0.10%) ⬇️

... and 42 files with indirect coverage changes

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 30, 2024
@sre-ci-robot sre-ci-robot merged commit bc4a9a1 into milvus-io:2.4 Mar 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants