-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return specific error code when encountering incomplete requery results #31343
fix: Return specific error code when encountering incomplete requery results #31343
Conversation
…results Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31343 +/- ##
==========================================
- Coverage 81.04% 81.03% -0.01%
==========================================
Files 980 980
Lines 143314 143320 +6
==========================================
- Hits 116147 116139 -8
- Misses 23273 23280 +7
- Partials 3894 3901 +7
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ry (#675) 1. Support retry on milvus errors. 2. Retry on ErrInconsistentRequery for search and hybrid search operations. issue: milvus-io/milvus#29656 related milvus pr: milvus-io/milvus#31343 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…results (milvus-io#31343) Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
During requery, segments may change (e.g., due to compaction), so we need to return specific error codes when encountering incomplete requery results. Clients can then retry to avoid this issue.
issue: #29656