Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return specific error code when encountering incomplete requery results #31343

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

bigsheeper
Copy link
Contributor

During requery, segments may change (e.g., due to compaction), so we need to return specific error codes when encountering incomplete requery results. Clients can then retry to avoid this issue.

issue: #29656

…results

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.03%. Comparing base (17b4938) to head (e5bfd2a).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31343      +/-   ##
==========================================
- Coverage   81.04%   81.03%   -0.01%     
==========================================
  Files         980      980              
  Lines      143314   143320       +6     
==========================================
- Hits       116147   116139       -8     
- Misses      23273    23280       +7     
- Partials     3894     3901       +7     
Files Coverage Δ
pkg/util/merr/errors.go 85.71% <ø> (ø)
pkg/util/merr/utils.go 89.33% <100.00%> (+0.09%) ⬆️
internal/proxy/task_search.go 83.98% <0.00%> (ø)

... and 32 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Mar 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 18, 2024
@sre-ci-robot sre-ci-robot merged commit c4ace0f into milvus-io:master Mar 18, 2024
13 of 14 checks passed
sre-ci-robot pushed a commit to milvus-io/milvus-sdk-go that referenced this pull request Mar 18, 2024
…ry (#675)

1. Support retry on milvus errors.
2. Retry on ErrInconsistentRequery for search and hybrid search
operations.

issue: milvus-io/milvus#29656

related milvus pr: milvus-io/milvus#31343

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Mar 18, 2024
…results (#31343) (#31359)

During requery, segments may change (e.g., due to compaction), so we
need to return specific error codes when encountering incomplete requery
results. Clients can then retry to avoid this issue.

issue: #29656

pr: #31343

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Jul 29, 2024
…results (milvus-io#31343)

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 5, 2024
This PR cherry-picks the following PRs:

1. Return specific error codes when encountering incomplete requery
results error. #31343
2. Retry on incomplete requery result in proxy.
#31713

issue: #34820

pr: #31343,
#31713

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants