Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support multiple vector search #29433

Merged
merged 2 commits into from
Jan 8, 2024
Merged

feat: Support multiple vector search #29433

merged 2 commits into from
Jan 8, 2024

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Dec 22, 2023

issue #25639

Signed-off-by: xige-16 xi.ge@zilliz.com

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/internal-api labels Dec 22, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 22, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 22, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Jan 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 4, 2024

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@xige-16
Support multiple vector search
4152a32 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (3561586) 80.82% compared to head (cb610a2) 83.68%.
Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #29433      +/-   ##
==========================================
+ Coverage   80.82%   83.68%   +2.85%     
==========================================
  Files         926      686     -240     
  Lines      127767   109601   -18166     
==========================================
- Hits       103271    91718   -11553     
+ Misses      21145    14502    -6643     
- Partials     3351     3381      +30
Files Coverage Δ
internal/proxy/task.go 85.68% <ø> (+0.19%) ⬆️
internal/proxy/util.go 90.10% <ø> (ø)
internal/querycoordv2/task/executor.go 72.83% <ø> (+0.61%) ⬆️
internal/querycoordv2/task/utils.go 91.30% <100.00%> (-1.01%) ⬇️
internal/querynodev2/segments/collection.go 90.51% <ø> (-0.34%) ⬇️
internal/querynodev2/segments/plan.go 69.44% <100.00%> (-5.12%) ⬇️
internal/querynodev2/segments/segment_loader.go 75.80% <100.00%> (-0.10%) ⬇️
internal/querynodev2/services.go 89.10% <100.00%> (-0.14%) ⬇️
pkg/metrics/metrics.go 100.00% <ø> (ø)
internal/querynodev2/segments/segment.go 78.56% <88.88%> (+0.20%) ⬆️
... and 5 more

... and 260 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jan 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Jan 8, 2024
@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 8, 2024
@sre-ci-robot sre-ci-robot merged commit 9702cef into milvus-io:master Jan 8, 2024
12 of 13 checks passed
@PowderLi PowderLi mentioned this pull request Jan 23, 2024
Closed
1 task
@congqixia congqixia mentioned this pull request Feb 1, 2024
Merged
sre-ci-robot pushed a commit to milvus-io/milvus-sdk-go that referenced this pull request Feb 2, 2024
@congqixia
enhance: Support hybrid search multiple vector fields (#663)
43e3bd2 
See also: milvus-io/milvus#25639
milvus pr:  milvus-io/milvus#29433

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xige-16 @czs007 @sre-ci-robot