Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test cases #28541

Merged
merged 1 commit into from
Nov 29, 2023
Merged

test: add test cases #28541

merged 1 commit into from
Nov 29, 2023

Conversation

NicoYuan1986
Copy link
Contributor

@NicoYuan1986 NicoYuan1986 commented Nov 17, 2023 •
edited
Loading

  1. modify test cases about output a non-existed field. issue: [Bug]: Search output a non-existed field behaves differently when dynamicField is enabled or not #28465
  2. add cases about creating collection using different language
  3. add test case about inserting a string value to a pk(int64) field
  4. add test case about search with expression using double quotes. issue: [Bug]: Query failed with double quotes #28365

@sre-ci-robot sre-ci-robot added area/test size/M Denotes a PR that changes 30-99 lines. sig/testing labels Nov 17, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

@NicoYuan1986

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@NicoYuan1986 NicoYuan1986 changed the title add test cases enhance: add test cases Nov 17, 2023
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 17, 2023
@NicoYuan1986 NicoYuan1986 changed the title enhance: add test cases test: add test cases Nov 17, 2023
@mergify mergify bot added the kind/test label Nov 17, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

yanliang567
yanliang567 reviewed Nov 20, 2023
View reviewed changes
tests/python_client/testcases/test_insert.py Outdated
collection_name = cf.gen_unique_str(prefix)
collection_w = self.init_collection_wrap(name=collection_name)
df = cf.gen_default_dataframe_data(1)
df[ct.default_int64_field_name] = ["2000000"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest gen 100 entities, and update one of them to be a string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good advice, I have already changed it.

tests/python_client/testcases/test_search.py
# 3. search with expression
_id = random.randint(0, default_nb)
string_value[_id] = string_value[_id].replace("\"", "\\\"")
expression = f"{default_string_field_name} == \"{string_value[_id]}\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also add more scenarios for multiple single/double quotes in the inserted string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@NicoYuan1986
test: add test cases
2ed9567 
Signed-off-by: nico <cheng.yuan@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 24, 2023

@NicoYuan1986 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@NicoYuan1986
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 24, 2023
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NicoYuan1986, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 845851e into milvus-io:master Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanliang567 yanliang567 yanliang567 left review comments

@binbinlv binbinlv Awaiting requested review from binbinlv

@zhuwenxing zhuwenxing Awaiting requested review from zhuwenxing

Assignees

@yanliang567 yanliang567

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/test lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicoYuan1986 @yanliang567 @sre-ci-robot