Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws-c-http missing #25055

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix aws-c-http missing #25055

merged 1 commit into from
Jun 21, 2023

Conversation

jiaoew1991
Copy link
Contributor

issue: #24056

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Jun 21, 2023
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

@jiaoew1991 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jun 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #25055 (857fb57) into master (a79fd1c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25055      +/-   ##
==========================================
- Coverage   82.02%   81.99%   -0.03%     
==========================================
  Files         792      792              
  Lines      105123   105123              
==========================================
- Hits        86227    86199      -28     
- Misses      15874    15899      +25     
- Partials     3022     3025       +3     
Impacted Files Coverage Δ
internal/core/src/segcore/FieldIndexing.h 75.00% <ø> (ø)
internal/storage/data_codec.go 66.30% <ø> (ø)
pkg/common/common.go 100.00% <ø> (ø)
pkg/util/funcutil/policy.go 73.52% <ø> (ø)
internal/datanode/compactor.go 75.53% <100.00%> (ø)
internal/datanode/flush_manager.go 89.78% <100.00%> (+0.64%) ⬆️

... and 17 files with indirect coverage changes

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@xige-16
Copy link
Contributor

xige-16 commented Jun 21, 2023

/lgtm

@congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 21, 2023
@mergify mergify bot added the ci-passed label Jun 21, 2023
@sre-ci-robot sre-ci-robot merged commit de78fe7 into milvus-io:master Jun 21, 2023
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants