Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws-c-io not found #24777

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Fix aws-c-io not found #24777

merged 1 commit into from
Jun 10, 2023

Conversation

jiaoew1991
Copy link
Contributor

issue: #24056

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Jun 9, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@cydrain
Copy link
Contributor

cydrain commented Jun 9, 2023

/lgtm

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #24777 (2111f53) into master (864c1bb) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24777      +/-   ##
==========================================
- Coverage   82.30%   81.92%   -0.39%     
==========================================
  Files         777      788      +11     
  Lines      102339   104591    +2252     
==========================================
+ Hits        84234    85688    +1454     
- Misses      15060    15862     +802     
+ Partials     3045     3041       -4     

see 172 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 10, 2023
@congqixia
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot merged commit e538540 into milvus-io:master Jun 10, 2023
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 10, 2023
zhagnlu pushed a commit to zhagnlu/milvus that referenced this pull request Jun 13, 2023
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants