Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws-c-cal lib missing #24610

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix aws-c-cal lib missing #24610

merged 1 commit into from
Jun 2, 2023

Conversation

jiaoew1991
Copy link
Contributor

issue: #24056 #24605

@jiaoew1991
Fix aws-c-cal lib missing
3667692 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 2, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #24610 (3667692) into master (31880ab) will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24610      +/-   ##
==========================================
- Coverage   82.64%   82.23%   -0.41%     
==========================================
  Files         767      778      +11     
  Lines      100984   103367    +2383     
==========================================
+ Hits        83456    85008    +1552     
- Misses      14528    15354     +826     
- Partials     3000     3005       +5

see 185 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia
congqixia approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jun 2, 2023
@sre-ci-robot sre-ci-robot merged commit 6b1712e into milvus-io:master Jun 2, 2023
@jiaoew1991 jiaoew1991 mentioned this pull request Jun 2, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaoew1991 @sre-ci-robot @congqixia