Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws-c-sdkutils #24085

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

jiaoew1991
Copy link
Contributor

issue: #24056

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels May 12, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 12, 2023
@mergify
Copy link
Contributor

mergify bot commented May 12, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #24085 (14fdc08) into master (4cd9f32) will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24085      +/-   ##
==========================================
- Coverage   82.13%   81.77%   -0.37%     
==========================================
  Files         754      755       +1     
  Lines       98668   100821    +2153     
==========================================
+ Hits        81044    82445    +1401     
- Misses      14644    15386     +742     
- Partials     2980     2990      +10     

see 181 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 12, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind improvement
/lgtm

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 13, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8bfb428 into milvus-io:master May 13, 2023
jiaoew1991 added a commit to jiaoew1991/milvus that referenced this pull request May 30, 2023
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants