Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete by expression method #578

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Sep 6, 2023

relate: #577

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #578 (52ef1fa) into master (684ef2d) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   82.79%   82.89%   +0.09%     
==========================================
  Files          40       40              
  Lines        3626     3647      +21     
==========================================
+ Hits         3002     3023      +21     
  Misses        511      511              
  Partials      113      113              
Files Changed Coverage Δ
client/client.go 28.94% <ø> (ø)
client/insert.go 80.98% <100.00%> (+1.40%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Sep 6, 2023
client/client.go Outdated Show resolved Hide resolved
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Sep 11, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Sep 11, 2023
@sre-ci-robot sre-ci-robot merged commit 849300d into milvus-io:master Sep 11, 2023
@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants