Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add cases about resource group and database #533

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

ThreadDao
Copy link
Contributor

See also: #495 #428

/kind improvement

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 1, 2023
@sre-ci-robot sre-ci-robot requested review from congqixia and sunby August 1, 2023 12:47
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #533 (4210955) into master (65d9013) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
- Coverage   82.59%   82.43%   -0.16%     
==========================================
  Files          39       39              
  Lines        3540     3542       +2     
==========================================
- Hits         2924     2920       -4     
- Misses        503      510       +7     
+ Partials      113      112       -1     
Files Changed Coverage Δ
client/options.go 59.45% <0.00%> (-1.66%) ⬇️

... and 1 file with indirect coverage changes

@mergify mergify bot added the ci-passed auto merge needed label label Aug 1, 2023
@congqixia congqixia added the test/ci intergration test label Aug 3, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 3, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Aug 3, 2023
@sre-ci-robot sre-ci-robot merged commit 8b6a432 into milvus-io:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XL Denotes a PR that changes 500-999 lines. test/ci intergration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants