Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make retry on ratelimit configurable #522

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#25693
/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 21, 2023
@sre-ci-robot sre-ci-robot requested a review from sunby July 21, 2023 03:29
@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #522 (1deb6eb) into v2.2.x (6a10d5c) will increase coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.2.x     #522      +/-   ##
==========================================
+ Coverage   79.99%   80.02%   +0.03%     
==========================================
  Files          35       36       +1     
  Lines        2844     2849       +5     
==========================================
+ Hits         2275     2280       +5     
+ Misses        458      457       -1     
- Partials      111      112       +1     
Impacted Files Coverage Δ
client/client.go 28.94% <ø> (-2.76%) ⬇️
client/rate_limit_interceptor.go 69.23% <33.33%> (ø)
client/config.go 70.37% <62.50%> (+3.02%) ⬆️
client/results.go 66.66% <66.66%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Jul 21, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 21, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a888a7a into milvus-io:v2.2.x Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants