Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default value #514

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Jul 14, 2023

Signed-off-by: lixinguo xinguo.li@zilliz.com
milvus-io/milvus#23337
/kind improvement

@sre-ci-robot sre-ci-robot requested review from congqixia and sunby July 14, 2023 03:46
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #514 (99cfeb1) into master (565c5e3) will decrease coverage by 0.47%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   83.62%   83.15%   -0.47%     
==========================================
  Files          38       38              
  Lines        3383     3438      +55     
==========================================
+ Hits         2829     2859      +30     
- Misses        447      471      +24     
- Partials      107      108       +1     
Impacted Files Coverage Δ
entity/columns.go 63.72% <0.00%> (-8.10%) ⬇️
client/insert.go 78.62% <66.66%> (-0.26%) ⬇️
entity/schema.go 94.92% <100.00%> (+0.77%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Jul 14, 2023
@smellthemoon smellthemoon force-pushed the support-default-value branch from 1e7f7ea to bf1081d Compare July 15, 2023 18:52
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 15, 2023
@mergify mergify bot removed the ci-passed auto merge needed label label Jul 15, 2023
@smellthemoon smellthemoon force-pushed the support-default-value branch 3 times, most recently from 116a963 to 07c7324 Compare July 16, 2023 17:09
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@smellthemoon smellthemoon force-pushed the support-default-value branch from 07c7324 to 99cfeb1 Compare July 16, 2023 17:31
@mergify mergify bot added the ci-passed auto merge needed label label Jul 16, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 18, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jul 18, 2023
@sre-ci-robot sre-ci-robot merged commit f58d114 into milvus-io:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants