Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use milvus-proto/go-api/v2 for master #489

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

congqixia
Copy link
Contributor

/kind improvement
See also milvus-io/milvus#24717

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 9, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from sunby June 9, 2023 09:09
@sre-ci-robot sre-ci-robot added approved review approved size/XL Denotes a PR that changes 500-999 lines. labels Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #489 (7ec0475) into master (cc1c52d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files          36       36           
  Lines        3319     3319           
=======================================
  Hits         2791     2791           
  Misses        425      425           
  Partials      103      103           
Impacted Files Coverage Δ
client/admin.go 83.33% <ø> (ø)
client/alias.go 100.00% <ø> (ø)
client/authentication.go 100.00% <ø> (ø)
client/collection.go 87.81% <ø> (ø)
client/connect.go 80.51% <ø> (ø)
client/data.go 69.91% <ø> (ø)
client/index.go 77.95% <ø> (ø)
client/insert.go 78.87% <ø> (ø)
client/maintainance.go 95.55% <ø> (ø)
client/options.go 68.00% <ø> (ø)
... and 13 more

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Jun 10, 2023
@jiaoew1991
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jun 10, 2023
@sre-ci-robot sre-ci-robot merged commit 06b4a4a into milvus-io:master Jun 10, 2023
@congqixia congqixia deleted the goapi_v2_master branch June 13, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants