Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test teardown clear all collections #419

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

ThreadDao
Copy link
Contributor

@ThreadDao ThreadDao commented Mar 9, 2023

  • Remove test teardown clear all collections

In order not to drop their collections when running with other types of tests

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 9, 2023
@sre-ci-robot sre-ci-robot requested review from congqixia and sunby March 9, 2023 12:53
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 9, 2023
@mergify mergify bot added ci-passed auto merge needed label test/ci intergration test labels Mar 9, 2023
@congqixia
Copy link
Contributor

Care to explain why shall we remove test case tear down for collection? @ThreadDao

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
@ThreadDao
Copy link
Contributor Author

Care to explain why shall we remove test case tear down for collection? @ThreadDao

Thanks for your reminder. I write the reason in the pr comment, please check.
And the reason is: In order not to drop their collections when running with other types of tests

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 14, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Mar 14, 2023
@sre-ci-robot sre-ci-robot merged commit 7fb93bf into milvus-io:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines. test/ci intergration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants