Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support get bulk insert progress #392

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Support get bulk insert progress #392

merged 1 commit into from
Feb 10, 2023

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Feb 4, 2023 •
edited
Loading

/kind improvement
related:#393

Signed-off-by: wayblink anyang.wang@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 4, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 4, 2023
@wayblink wayblink force-pushed the bulkinsert-progress-dev branch from 7b9cbd3 to a49311d Compare February 4, 2023 07:37
@codecov
Copy link

codecov bot commented Feb 4, 2023 •
edited
Loading

Codecov Report

Merging #392 (d5f10d4) into master (6ae3002) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   83.67%   83.50%   -0.17%     
==========================================
  Files          29       30       +1     
  Lines        3038     3044       +6     
==========================================
  Hits         2542     2542              
- Misses        404      410       +6     
  Partials       92       92
Impacted Files Coverage Δ
entity/bulkinsert.go 0.00% <0.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Feb 4, 2023
@wayblink @congqixia
Support get bulk insert progress
d5f10d4 
Signed-off-by: wayblink <anyang.wang@zilliz.com>
@congqixia congqixia force-pushed the bulkinsert-progress-dev branch from a49311d to d5f10d4 Compare February 9, 2023 09:51
congqixia
congqixia approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Feb 10, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Feb 10, 2023
@sre-ci-robot sre-ci-robot merged commit 47d534f into milvus-io:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wayblink @sre-ci-robot @congqixia