[Enhancement]: Add DescribeUser methods to map Users with Roles #698
Labels
kind/enhancement
New feature or request
Comments
sre-ci-robot
pushed a commit
that referenced
this issue
Apr 26, 2024
resolves: #698 I've added an entity: ``` type UserDescription struct { Name string Roles []string } ``` And two methods and tests for them: - `DescribeUser(ctx context.Context, username string) (entity.UserDescription, error)` - which returns UserDescription for a specific user. - `DescribeUsers(ctx context.Context) ([]entity.UserDescription, error)` - which returns UserDescription for all users presented. The thing that I want to raise is that I am not sure if it is feasible to return empty `UserDescription` entity in case the user from `DescribeUser` method doesn't exist, I would highly appreciate suggestions here. Also, I am not much familiar with the `milvus-sdk-go` codebase and this is my first PR here, so any comments/feedback/suggestions would be highly appreciated, thanks! --------- Signed-off-by: punkerpunker <gleb.vazhenin@team.bumble.dev> Co-authored-by: punkerpunker <gleb.vazhenin@team.bumble.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
What would you like to be added?
I would like to suggest a method to fetch Users with their Roles
Why is this needed?
I am currently writing the RBAC terraform provider for Milvus, and these entries are missing
Anything else?
No response
The text was updated successfully, but these errors were encountered: