Skip to content

Commit

Permalink
Change to one API
Browse files Browse the repository at this point in the history
Signed-off-by: Chao-Han Tsai <milton0825@gmail.com>
  • Loading branch information
milton0825 committed Apr 14, 2021
1 parent 0d4be96 commit 75b7edd
Showing 1 changed file with 13 additions and 20 deletions.
33 changes: 13 additions & 20 deletions protos/flyteidl/datacatalog/datacatalog.proto
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ service DataCatalog {
rpc AddTag (AddTagRequest) returns (AddTagResponse);
rpc ListArtifacts (ListArtifactsRequest) returns (ListArtifactsResponse);
rpc ListDatasets (ListDatasetsRequest) returns (ListDatasetsResponse);
rpc AcquireLease (AcquireLeaseRequest) returns (AcquireLeaseResponse);
rpc GetLeaseInfo (GetLeaseInfoRequest) returns (GetLeaseInfoResponse);
rpc GetOrReserveArtifact (GetOrReserveArtifactRequest) returns (GetOrReserveArtifactResponse);
}

message CreateDatasetRequest {
Expand Down Expand Up @@ -95,24 +94,24 @@ message ListDatasetsResponse {
string next_token = 2;
}

message AcquireLeaseRequest {
DatasetID dataset_id = 2;
string tag_name = 3;
google.protobuf.Timestamp expire_at = 4;
google.protobuf.Timestamp prev_expire_at = 5;
}
message ReservationStatus {

message AcquireLeaseResponse {
}

message GetOrReserveArtifactRequest {
DatasetID dataset_id = 1;
string tag_name = 2;
google.protobuf.Timestamp expire_at = 3;
}

message GetLeaseInfoRequest {
DatasetID dataset_id = 2;
string tag_name = 3;
enum ReservationStatus {
SUCCESS = 0;
FAILED = 1;
}

message GetLeaseInfoResponse {
ArtifactLease artifact_lease = 1;
message GetOrReserveArtifactResponse {
Artifact artifact = 1;
ReservationStatus reservation_status = 2;
}

message Dataset {
Expand Down Expand Up @@ -159,12 +158,6 @@ message Metadata {
map<string, string> key_map = 1; // key map is a dictionary of key/val strings that represent metadata
}

message ArtifactLease {
DatasetID dataset = 1;
string tag_name = 2;
google.protobuf.Timestamp expire_at = 3;
}

// Filter expression that is composed of a combination of single filters
message FilterExpression {
repeated SinglePropertyFilter filters = 1;
Expand Down

0 comments on commit 75b7edd

Please sign in to comment.