Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add rel_path output for relative path #6

Merged
merged 2 commits into from
Jan 18, 2022
Merged

chore: add rel_path output for relative path #6

merged 2 commits into from
Jan 18, 2022

Conversation

b6pzeusbc54tvhw5jgpyw8pwz2x6gs
Copy link
Contributor

Added rel_path for resolving #5

ofhouse
ofhouse requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@ofhouse ofhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing with the example, otherwise looks good 👍

examples/download/main.tf Outdated Show resolved Hide resolved
@b6pzeusbc54tvhw5jgpyw8pwz2x6gs @ofhouse
chore: change source to 'milliHQ/download/npm' in example
75584ed 
Co-authored-by: Felix Haus <ofhouse@users.noreply.github.com>
@ofhouse ofhouse linked an issue Jan 18, 2022 that may be closed by this pull request
The relative path of downloaded file is needed. #5
Closed
@ofhouse ofhouse merged commit b67dc7d into milliHQ:main Jan 18, 2022
@ofhouse
Copy link
Member

ofhouse commented Jan 18, 2022

Now released in v2.1.0, thanks for the contribution! 🎉

Merged
@b6pzeusbc54tvhw5jgpyw8pwz2x6gs b6pzeusbc54tvhw5jgpyw8pwz2x6gs deleted the add-relative-path-output branch January 18, 2022 13:49
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofhouse ofhouse ofhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The relative path of downloaded file is needed.
2 participants
@b6pzeusbc54tvhw5jgpyw8pwz2x6gs @ofhouse