Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump milliHQ/download/npm from 1.1.0 to 2.0.0 #69

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

ofhouse
Copy link
Member

@ofhouse ofhouse commented Sep 18, 2021

When upgrading from a previous version of the module, Terraform may fail with an error that the final plan has changed during apply.
That was caused by the milliHQ/download/npm module that downloaded the source of the Lambda in parallel to running the apply.
In 2.0.0 this behavior was fixed, so that Terraform waits until the download is finished before progreeding.

Relates to: milliHQ/terraform-npm-download#3.
Fixes: #68.

When upgrading from a previous version of the module, Terraform may
fail with an error that the final plan has changed during apply.
That was caused by the milliHQ/download/npm module that downloaded the
source of the Lambda in parralel to running the apply.
In 2.0.0 this behavior was fixed, so that Terraform waits until the
download is finished before progreeding.
@ofhouse ofhouse added this to the v11.1.3 milestone Sep 18, 2021
@ofhouse ofhouse merged commit 6c3c040 into main Sep 18, 2021
@ofhouse ofhouse deleted the fix-inconsitent-final-plan branch September 18, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while trying to add new domain
1 participant