Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor class names to match PEP8 recommendations #31

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Refactor class names to match PEP8 recommendations #31

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8f13a3
Update call class names to PEP8 recommendation
mill1000 Aug 16, 2023
06d6a08
Update enum member names to PEP8 recommendations
mill1000 Aug 16, 2023
41eb39c
Fix missed type hint refactoring
mill1000 Aug 18, 2023
bbdcafc
Restructure some files and module names
mill1000 Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missed type hint refactoring
  • Loading branch information
@mill1000
mill1000 committed Aug 18, 2023
commit 41eb39c66fd212ef1f1d941800238758d62b9de4
10 changes: 5 additions & 5 deletions msmart/device/AC/appliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def target_temperature(self, temperature_celsius: float) -> None:
self._target_temperature = temperature_celsius

@property
def operational_mode(self) -> operational_mode_enum:
def operational_mode(self) -> OperationalMode:
return self._operational_mode

@operational_mode.setter
Expand All @@ -296,7 +296,7 @@ def operational_mode(self, mode: OperationalMode) -> None:
self._operational_mode = mode

@property
def fan_speed(self) -> fan_speed_enum:
def fan_speed(self) -> FanSpeed:
return self._fan_speed

@fan_speed.setter
Expand All @@ -306,7 +306,7 @@ def fan_speed(self, speed: FanSpeed) -> None:
self._fan_speed = speed

@property
def swing_mode(self) -> swing_mode_enum:
def swing_mode(self) -> SwingMode:
return self._swing_mode

@swing_mode.setter
Expand Down Expand Up @@ -394,11 +394,11 @@ def off_timer(self):
return self._off_timer

@property
def supported_operation_modes(self) -> List[operational_mode_enum]:
def supported_operation_modes(self) -> List[OperationalMode]:
return self._supported_op_modes

@property
def supported_swing_modes(self) -> List[swing_mode_enum]:
def supported_swing_modes(self) -> List[SwingMode]:
return self._supported_swing_modes

@property
Expand Down