Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tagged docker images reporting different version than tag #138

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mill1000
Copy link
Owner

@mill1000 mill1000 commented Jul 10, 2024

Currently the Docker images don't have msmart-ng versions that match their tag.

docker run --network=host ghcr.io/mill1000/msmart-ng:2024.7.0 -v
msmart version: 2024.7.1.dev0+gab34eb4.d20240710

Update dockerignore to ensure git status is clean when building Docker images, to ensure the built version matches the tag.

@mill1000 mill1000 added the bug Something isn't working label Jul 10, 2024
@mill1000 mill1000 merged commit 1a821df into main Jul 10, 2024
7 checks passed
@mill1000 mill1000 deleted the issue/docker_not_clean branch July 10, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant