Accept valid checksum or CRC for device responses #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty. Addresses some issues seen in #11
Return None when a payload fails to validate
…te errors when short packet arrives. Add more units tests
… to ensure they don't overwrite the valus from unpack(). Feels like a hack to me!
- Eliminate the abstract unpack method and have the derived classes parse the data as part of their own __init__ methods - Raise exceptions on bad CRCs and checksums and catch them at the appliance level - Make the payload member of the base class a property - Pass around a memoryview for efficient slicing
|
Waiting to confirm this PR functions on my own system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a response through if either a CRC or checksum matches. Some devices appear to protect the response payload with a 2nd checksum instead of a CRC8. See issue #9 for related reports.
Additionally this PR
Close #9 and close mill1000/midea-ac-py#11