Replace CtorDtor with simplified FromTo #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ec7f81 to
ee11077
Compare
`FromTo` decouples and simplifies the strategy to generate the `from` and `to` functions. This will let us more easily add other strategies in the future and refine the choice of which strategy to use in which case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromTodecouples and simplifies the strategy to generate thefromandtofunctions. This will let us more easily addother strategies in the future and refine the choice of which
strategy to use in which case.
This is a prerequisite for fixing #1059 but does not yet fix it.
The issue demonstrates that in certain cases we might want to use
fromApplyandtoGettersfor case classes.