Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve workspace root detection. Fix config loading and validation. #143

Merged
merged 5 commits into from
Aug 19, 2022

Conversation

milesj
Copy link
Owner

@milesj milesj commented Aug 19, 2022

Packemon is run in 4 different contexts:

  • Polyrepo root (builds 1 package)
  • Monorepo root (builds all packages)
  • Monorepo root with filters (builds N packages)
  • Monorepo project (builds 1 package)

The first 3 work just fine, as they were the intended developer flow for Packemon. However, the 4th is currently "broken". Packages build just fine, but configuration (package.config.js, etc) are resolved incorrectly, and any package.json validation (mainly repository) fails incorrectly.

To solve this problem, I must detect the "repo root".

@milesj milesj merged commit c01154d into master Aug 19, 2022
@milesj milesj deleted the workspace-detect branch August 19, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant