Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy raise on known errors #144

Merged
merged 7 commits into from
Mar 2, 2024
Merged

Conversation

milesgranger
Copy link
Owner

@milesgranger milesgranger commented Mar 2, 2024

Part of #142.

Raise on errors known to fail with PyPy.

  • No bytes or memoryview for target output (only relavent for de/compress_into methods)
  • Will sometimes fail with multidimensional numpy arrays depending on dtype, notably datetime dtypes and a few others.

Additionally this:

  • Updates CI to run the tests on PyPy environments
  • Update PythonBuffer::as_slice_mut to return a Result so we can raise if we're on PyPy in the context mentioned above for raising errors.
  • Better checks from C api for checks comparing to 1 for true.
  • Drops PyPy 3.7 and 3.8, adding 3.10 and keeping 3.9.
  • Updates Cargo.lock
  • Parametrized pypy builds for macos and linux, Windows fails but that's a bigger issue

@milesgranger milesgranger changed the title Pypy raise on known errors PyPy raise on known errors Mar 2, 2024
@milesgranger milesgranger force-pushed the pypy-raise-on-known-errors branch from 9f56f6d to 32f75f1 Compare March 2, 2024 16:17
@milesgranger milesgranger force-pushed the pypy-raise-on-known-errors branch from d391eb4 to fbae14b Compare March 2, 2024 18:02
@milesgranger milesgranger merged commit 2cc2deb into master Mar 2, 2024
62 checks passed
@milesgranger milesgranger deleted the pypy-raise-on-known-errors branch March 2, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant