Skip to content

Commit

Permalink
fix nim-lang#14132 dsymutil should not be called on static libraries (n…
Browse files Browse the repository at this point in the history
…im-lang#14133) [backport:1.2]
  • Loading branch information
timotheecour authored Apr 27, 2020
1 parent dedb04f commit b8d7a98
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions compiler/extccomp.nim
Original file line number Diff line number Diff line change
Expand Up @@ -850,12 +850,12 @@ proc execLinkCmd(conf: ConfigRef; linkCmd: string) =

proc maybeRunDsymutil(conf: ConfigRef; exe: AbsoluteFile) =
when defined(osx):
if optCDebug notin conf.globalOptions: return
# if needed, add an option to skip or override location
let cmd = "dsymutil " & $(exe).quoteShell
conf.extraCmds.add cmd
tryExceptOSErrorMessage(conf, "invocation of dsymutil failed."):
execExternalProgram(conf, cmd, hintExecuting)
if optCDebug in conf.globalOptions and optGenStaticLib notin conf.globalOptions:
# if needed, add an option to skip or override location
let cmd = "dsymutil " & $(exe).quoteShell
conf.extraCmds.add cmd
tryExceptOSErrorMessage(conf, "invocation of dsymutil failed."):
execExternalProgram(conf, cmd, hintExecuting)

proc execCmdsInParallel(conf: ConfigRef; cmds: seq[string]; prettyCb: proc (idx: int)) =
let runCb = proc (idx: int, p: Process) =
Expand Down

0 comments on commit b8d7a98

Please sign in to comment.