Skip to content

Commit

Permalink
close nim-lang#12746; minor cleanup (nim-lang#14379)
Browse files Browse the repository at this point in the history
  • Loading branch information
timotheecour authored May 17, 2020
1 parent 42e8082 commit 51578be
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/nimdoc/readme.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
the html validation is tested by nimdoc/tester.nim
the runnableExamples + nim doc logic (across backend) is tested here
## links
* $nim/nimdoc/tester.nim: tests html validation
* $nim/tests/nimdoc/: tests `runnableExamples` + `nim doc` logic
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,25 @@ proc fun*() =
doAssert declared(isAlphaAscii)
echo "foo7"

when true: # issue #12746
# this proc on its own works fine with `nim doc`
proc goodProc*() =
runnableExamples:
try:
discard
except:
# just the general except will work
discard

# FIXED: this proc fails with `nim doc`
proc badProc*() =
runnableExamples:
try:
discard
except IOError:
# specifying Error is culprit
discard

# also check for runnableExamples at module scope
runnableExamples:
block:
Expand Down

0 comments on commit 51578be

Please sign in to comment.