Transition mila serve to RemoteV2
#107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mila serve to RemoteV2
186050a to
57785c4
Compare
Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Add `sbatch` for RemoteV2 Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Add better docstrings Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Move `code` command to code_command, add new impl Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Fix circular import issue Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Fix import of `code_v1` Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Use new `code` impl in integration test Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Fix bug in `is_already_logged_in` Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Adjust `mila code` integration test Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Add mark to tests that launch jobs Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Fix typing error for py38 Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Fix typing error for py38 Signed-off-by: Fabrice Normandin <normandf@mila.quebec> Fix missing imports in common.py Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
39bde1c to
eed46e7
Compare
|
Too old and stale. Will start over in a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
ComputeNode,LocalV2+ deprecateRemoteV1andLocalV1#112mila serveThis PR makes
mila serve (...)commands use the new RemoteV2 class (which supports SSH keys with passphrases and clusters with 2FA enabled.