Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.28.2 broken. 1.28.1 works. #6699

Closed
barkoder opened this issue Dec 21, 2024 · 3 comments
Closed

1.28.2 broken. 1.28.1 works. #6699

barkoder opened this issue Dec 21, 2024 · 3 comments

Comments

@barkoder
Copy link

$ gallery-dl -v
Python path configuration:
  PYTHONHOME = (not set)
  PYTHONPATH = (not set)
  program name = 'C:\gallery-dl.exe'
  isolated = 1
  environment = 0
  user site = 0
  import site = 0
  sys._base_executable = 'C:\\gallery-dl.exe'
  sys.base_prefix = ''
  sys.base_exec_prefix = ''
  sys.executable = 'C:\\gallery-dl.exe'
  sys.prefix = ''
  sys.exec_prefix = ''
  sys.path = [
    'C:\\gallery-dl.exe',
  ]
Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

Current thread 0x00001f5c (most recent call first):
<no Python frame>

1.28.1 works

$ gallery-dl -v
[gallery-dl][debug] Version 1.28.1 - Executable (stable/windows)
[gallery-dl][debug] Python 3.8.10 - Windows-7-6.1.7601-SP1
[gallery-dl][debug] requests 2.32.3 - urllib3 2.2.3
usage: gallery-dl-OLD.exe [OPTION]... URL...
gallery-dl-OLD.exe: error: The following arguments are required: URL
Use 'gallery-dl --help' to get a list of all options.
@onmyouji
Copy link

onmyouji commented Dec 21, 2024

Can confirm that I'm having the same issue with the standalone executable, 1.28.1 works just fine.

I'm on Windows 10 Home Version 22H2 (OS Build 19045.5247)

@mikf mikf added the bug label Dec 21, 2024
@mikf
Copy link
Owner

mikf commented Dec 21, 2024

I've re-built the v1.28.2 .exe without making any changes to anything and now it works:
https://github.com/mikf/gallery-dl/releases/download/v1.28.2/gallery-dl.exe

The broken one was only 10.4 MB, while the working one is 12.5 MB.

@barkoder
Copy link
Author

Fixed. Thanks @mikf .

mikf added a commit that referenced this issue Dec 23, 2024
to prevent issues like #6699 from happening again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants