[WIP] [V3] New ModelAdapter #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adjust all methods and add additional internal methods (which need to be implemented in the IItemAdapter)
Add an IdDistributor interface to make id distribution to each item flexible and extendable. This change also stores the id distributor instance to the item adapter. The default implementation is stored static inside the interface so the atomic long is shared with all item adapters to not collicate with an second item adapter instance.
FabianTerhorst
commented
Jul 16, 2017
| return item; | ||
| } | ||
| }); | ||
| super((IInterceptor<Item, Item>) IInterceptor.DEFAULT); |
There was a problem hiding this comment.
static generic doesnt work, not sure about an other way without an cast.
|
|
||
| public IIdDistributor<Item> getIdDistributor() { | ||
| if (mIdDistributor == null) { | ||
| return (IIdDistributor<Item>) IIdDistributor.DEFAULT; |
There was a problem hiding this comment.
static generic doesnt work, not sure about an other way without an cast.
* add script to simplify release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you want to make an own implementation that depends on an id increasement you have to share the implementation to all item adapters or make the id static.