Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndlessScroll - Current page value #399

Closed
rafakob opened this issue Apr 20, 2017 · 1 comment
Closed

EndlessScroll - Current page value #399

rafakob opened this issue Apr 20, 2017 · 1 comment
Assignees
@FabianTerhorst
Labels
enhancement
Milestone
v3.0.0

Comments

@rafakob
Copy link

rafakob commented Apr 20, 2017

Why in EndlessRecyclerOnTopScrollListener initial current page value is set to 0 and in EndlessRecyclerOnScrollListener is set to 1?

https://github.com/mikepenz/FastAdapter/blob/develop/library-extensions/src/main/java/com/mikepenz/fastadapter_extensions/scroll/EndlessRecyclerOnTopScrollListener.java#L13

https://github.com/mikepenz/FastAdapter/blob/develop/library-extensions/src/main/java/com/mikepenz/fastadapter_extensions/scroll/EndlessRecyclerOnScrollListener.java#L19

Can't find any reason for that.
@rafakob rafakob changed the title EndelssScreoll - Current page value EndelssScroll - Current page value Apr 21, 2017
@FabianTerhorst FabianTerhorst mentioned this issue May 20, 2017
Closed
14 tasks
@FabianTerhorst FabianTerhorst added this to the v3.0.0 milestone May 22, 2017
@FabianTerhorst FabianTerhorst changed the title EndelssScroll - Current page value EndlessScroll - Current page value May 22, 2017
mikepenz added a commit that referenced this issue Jun 9, 2017
@mikepenz
* the initial index of the EndlessRecclerOnScrollListener is now al…
cb882d9 
…so 0

  * FIX #399
@mikepenz
Copy link
Owner

mikepenz commented Jun 9, 2017

This will be fixed with v3

@mikepenz mikepenz closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabianTerhorst FabianTerhorst

Labels
enhancement
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@mikepenz @FabianTerhorst @rafakob