Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Decode text nodes before passing to React #18

Merged
merged 32 commits into from
Apr 25, 2016

Conversation

aknuds1
Copy link
Collaborator

@aknuds1 aknuds1 commented Feb 3, 2016

Text nodes must be decoded so that React doesn't escape character entities, such as >.

@lithin
Copy link
Contributor

lithin commented Feb 3, 2016

This looks great!

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Feb 3, 2016

@lithin 👍

@mikenikles
Copy link
Owner

Thanks @aknuds1, could you please update your branch with the latest master? I'm happy to merge it.

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Feb 8, 2016

@mikenikles Done.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d39f3be on aknuds1:decode-text into 3bf4bd4 on mikenikles:master.

This reverts commit d39f3be, reversing
changes made to 6a10d33.
@aknuds1
Copy link
Collaborator Author

aknuds1 commented Apr 24, 2016

@mikenikles Will you please merge this soon?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 72a2ae7 on aknuds1:decode-text into 3bf4bd4 on mikenikles:master.

@mikenikles
Copy link
Owner

@aknuds1 Could you please update your branch one last time? My apologies for not being active with this project for so long. I'm now back and plan to push a release asap. Thanks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c365291 on aknuds1:decode-text into 273f4a4 on mikenikles:master.

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Apr 25, 2016

@mikenikles Done.

@mikenikles
Copy link
Owner

Thanks @aknuds1!

@mikenikles mikenikles merged commit f1efdbb into mikenikles:master Apr 25, 2016
@aknuds1 aknuds1 deleted the decode-text branch April 27, 2016 14:00
@mikenikles mikenikles modified the milestone: v1.0.0 May 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants