-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracted KnnIndexer class out of KnnGraphTester and moving to a knn package #254
Conversation
Hi @msokolov : If you find time please review and help with merge. |
de9df49
to
cac5a3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you undo the output format change? I guess if markdown output is desired we could either post-process or add a command line option to control the format?
src/main/knn/KnnGraphTester.java
Outdated
@@ -557,7 +565,22 @@ private void testSearch(Path indexPath, Path queryPath, Path outputPath, int[][] | |||
totalVisited /= numIters; | |||
System.out.printf( | |||
Locale.ROOT, | |||
"%5.3f\t%5.2f\t%d\t%d\t%d\t%d\t%d\t%d\t%.2f\t%s\n", | |||
"|%s\t|%s\t|%s\t|%s\t|%s\t|%s\t|%s\t|%s\t|%s\t|%s|\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with e code re-org but would prefer to keep the output in TSV format so it can be consumed by other tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds right. Will revert this part. My thought was that the output is generally pasted in the comments here so it would be better to pre-format it into md table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted to csv format.
cac5a3e
to
166a424
Compare
sorry I lost track of this! merging now... |
I am working on fixing this, as this breaks quantization, and adding options to quantize to 4bits. |
In this PR
knn
package.Tests :
Also tested by passing the
-indexPath
to KnnGraphTester from knnPerfTest.py. Works fine.Was able to run the command correctly and get output like