Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs instead of IDs #1

Merged
merged 1 commit into from
Dec 11, 2017
Merged

URLs instead of IDs #1

merged 1 commit into from
Dec 11, 2017

Conversation

mikemartin
Copy link
Owner

As I'm sure you know, assets IDs were replaced by URLs in v2.5.0.

FYI: This works perfectly for my usecase - thanks you for sharing it:

  • Portfolio site with a global grid field to allow client to add their social media channels
  • Grid has an asset field to set an SVG file
  • Need to inline the SVG in order to style with CSS (fill colour changes depending on context)

As I'm sure you know, assets IDs were replaced by URLs in v2.5.0.

FYI: This works perfectly for my usecase - thanks you for sharing it:
- Portfolio site with a global grid field to allow client to add their social media channels
- Grid has an asset field to set an SVG file
- Need to inline the SVG in order to style with CSS (fill colour changes depending on context)
@mikemartin mikemartin merged commit be48bc7 into mikemartin:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants