Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for catkin tools? #2

Closed
romainreignier opened this issue Aug 13, 2018 · 7 comments
Closed

Support for catkin tools? #2

romainreignier opened this issue Aug 13, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@romainreignier
Copy link

Nice package!
I have already tried to do code coverage on ROS packages and I had to write some scripts to call the lcov stuff by hand and with hardcoded paths so this package is welcomed!

But do you know how to invoke it with catkin tools?

Thanks

@mikeferguson
Copy link
Owner

So, in theory, this should work:

catkin config --cmake-args -DENABLE_COVERAGE_TESTING=ON
catkin build PACKAGE_NAME --no-deps
catkin build PACKAGE_NAME -v -no-deps --catkin-make-args PACKAGE_NAME_coverage

And that does appear to run things, but for some reason the extraction fails part way through... although the files it is working on look identical to what is generated through catkin_make.

I'm not sure what is going on -- will have to take a closer look later.

@mikeferguson mikeferguson added the enhancement New feature or request label Aug 13, 2018
@mikeferguson
Copy link
Owner

Appears to be some sort of escaping issue? The following patch appears to work with both catkin_build and catkin_make: f3fc68d

If you have a chance to try those commands with the catkin_build_fix branch, do let me know how it goes.

@romainreignier
Copy link
Author

Thanks!

With the fix, the command you gave me works fine but not with master version.

Actually, I was missing the --catkin-make-args part in the catkin tools command.

@mikeferguson
Copy link
Owner

Great. I’m going to add my command set to the readme and then I’ll get that merged into master and released

@romainreignier
Copy link
Author

Do you plan to release it for Melodic too?

@mikeferguson
Copy link
Owner

It was released into Melodic before Kinetic -- but the sync hasn't happened yet.

@romainreignier
Copy link
Author

Oh, great!

knorth55 added a commit to knorth55/code_coverage that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants