Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite-studio.portable - Update URL patterns to reflect new filenames #178

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

brogers5
Copy link
Contributor

  • Does this PR meet the requirements:
  • The commit messages are appropriate
  • This has been tested as far as practicable to ensure intended functionality is fine
  • What kind of change does this PR introduce? (Bug/issue fix, new package, documentation update, etc...)

Bug fix

  • What does this PR accomplish? (Links to issues are acceptable)

This should resolve the current update script failure for sqlite-studio.portable that started occurring as of v3.4.14's publication on January 16th:

Can't validate URL
Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (404) Not Found.":https://github.com/pawelsalawa/sqlitestudio/releases/download/3.4.14/sqlitestudio_x64-3.4.14.zip

The maintainer has changed the filename pattern for the published assets, and the update script's URL patterns needed to be adjusted accordingly.

  • Does this PR introduce a breaking change or require work elsewhere?

No

  • Other context/information:

N/A

@brogers5 brogers5 marked this pull request as ready for review January 28, 2025 23:07
Copy link
Owner

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your help with updating this package 🙂

@mikeee mikeee merged commit 5361cc5 into mikeee:master Jan 29, 2025
2 of 3 checks passed
@brogers5 brogers5 deleted the sqlite-studio.portable/fix-update branch January 29, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants