Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chardet -> charset-normalizer #2355

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chardet -> charset-normalizer #2355

merged 1 commit into from
Feb 12, 2025

Conversation

mjd3
Copy link
Contributor

@mjd3 mjd3 commented Feb 11, 2025 •
edited
Loading

This PR removes chardet as an easy dep and replaces it with charset_normalizer which is faster, has a smaller wheel, is more robust, and has an MIT license to match this project.

More info here: https://github.com/jawah/charset_normalizer

@mikedh mikedh changed the base branch from main to release/2D February 12, 2025 00:06
@mikedh mikedh merged commit ad3db3e into mikedh:release/2D Feb 12, 2025
9 checks passed
@mikedh
Copy link
Owner

mikedh commented Feb 12, 2025

Looks like a nice project and solid improvement over chardet, thanks for the update!

@mikedh mikedh mentioned this pull request Feb 12, 2025
Merged
mikedh added a commit that referenced this pull request Feb 12, 2025
@mikedh
Release: Face normal fix (#2354)
efca179 
- fixes `mesh.face_normals` for (n, 2) vertices (to always be 3D +Z),
rather than crashing
- test and fix #2345 
- release #2352
- release #2348 
- release #2355
@mjd3 mjd3 deleted the mjd3/charset-normalizer branch February 12, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjd3 @mikedh