Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86 condition for openctm #2343

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

nepfaff
Copy link
Contributor

@nepfaff nepfaff commented Jan 22, 2025

OpenCTM doesn't support Mac ARM:

ERROR: Could not find a version that satisfies the requirement openctm==0.0.6 (from versions: none)
ERROR: No matching distribution found for openctm==0.0.6

This follows the style from the embreex dependency that has similar issues.

@mikedh mikedh changed the base branch from main to followup/dep January 22, 2025 17:00
@mikedh mikedh merged commit 8d7d0d2 into mikedh:followup/dep Jan 22, 2025
9 checks passed
@mikedh
Copy link
Owner

mikedh commented Jan 22, 2025

Thanks for the PR! Just out of curiosity, how are you managing your trimesh dependency? There are multiple "helper" extras, none of which are required, and depending on anything other than trimesh[easy] is unlikely to work on all platforms.

For upstream projects, it's a lot easier to manage the poetry/UV/requirements lock files with exactly the soft dependencies that a project actually uses, i.e. trimesh, scipy, xatlas rather than using an extra, since just trimesh will only pull in numpy.

@nepfaff nepfaff deleted the add_x86_condition_for_openctm branch January 22, 2025 17:50
@nepfaff
Copy link
Contributor Author

nepfaff commented Jan 22, 2025

We currently depend on trimesh[recommend] as we need some of the dependencies there for parts of trimesh that we are using. However, only depending on trimesh and the exact soft dependencies that we actually need is a good suggestion and seems like the most robust way to handle this.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants