Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to numpy array if need #2286

Merged

Conversation

michaelbratsch
Copy link
Contributor

Due to commit 7f2aa95 related to issue #2257, the function normals does not accept containers such as lists for the parameter triangles anymore. This was possible before due to the call of cross which itself could handle that.

@mikedh mikedh changed the base branch from main to release/revolve September 17, 2024 18:32
@mikedh
Copy link
Owner

mikedh commented Sep 17, 2024

Thanks for the fix!!

@mikedh mikedh merged commit e62a22c into mikedh:release/revolve Sep 17, 2024
9 checks passed
@mikedh mikedh mentioned this pull request Sep 17, 2024
@michaelbratsch michaelbratsch deleted the fix/convert_to_numpy_array branch September 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants