Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grouping.hashable_rows
overflowing an integer.float_to_int
to anint64
on integer input rather than returning any integer type. I also disabled the "int32 vs int64" choice based on maximum value as it may have provided a speedup in some cases, but making this function simpler and have consistent return types seems more valuable. The type hint will be checked by Beartype in the docker image tests.Traceback for posterity: