Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mike,
Thanks again for sharing trimesh with the community. I noticed a tiny bug in the implementation of "stitch()". More specifically: the implementation of
unitize(...)
trimesh/trimesh/util.py
Lines 128 to 129 in aa3cb56
returns the normals after masking with
valid
whencheck_valid=True
. However, in the current implementation of stitchtrimesh/trimesh/repair.py
Line 438 in 3d5af39
This PR contains a quick fix to the problem.
Thanks.
-- Adrish