Update visual.gloss.specular_to_pbr to align gltf 2.0 material specs

mikedh · Jul 13, 2024 · 6c80e24 · 6c80e24
1 parent 85b4bd1
commit 6c80e24
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/tests/test_gltf.py b/tests/test_gltf.py
@@ -307,7 +307,8 @@ def test_specular_glossiness(self):
         )
         assert metallic_roughness.shape[0] == 84 and metallic_roughness.shape[1] == 71
 
-        metallic = metallic_roughness[:, :, 0]
+        # https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#metallic-roughness-material
+        metallic = metallic_roughness[:, :, 2]
         roughness = metallic_roughness[:, :, 1]
 
         assert g.np.allclose(metallic[0, 0], 0.231, atol=0.004)

diff --git a/trimesh/visual/gloss.py b/trimesh/visual/gloss.py
@@ -360,7 +360,7 @@ def convert_texture_lin2srgb(texture):
         # we need to use RGB textures, because 2 channel textures can cause problems
         result["metallicRoughnessTexture"] = toPIL(
             np.concatenate(
-                [metallic, 1.0 - glossiness, np.zeros_like(metallic)], axis=-1
+                [np.zeros_like(metallic), 1.0 - glossiness, metallic], axis=-1
             ),
             mode="RGB",
         )