Make Buildable@paginate compatible with Laravel 10.3.0 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for the merge to happen. If it does, the code causing this breaking change will be reverted in this PR, so there will be no need for further changes. |
mikebronner
approved these changes
Mar 9, 2023
|
@mikebronner In this PR laravel/framework#46406, the change in Laravel has been reverted. Maybe it will be considered in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue referenced in #445. Laravel 10.3.0 added a
$totalparameter toIlluminate\Database\Eloquent\Builder::paginate. This PR adds the same parameter toGeneaLabs\LaravelModelCaching\Traits\Buildable::paginateto eliminate PHP errors about a mismatch in function signature.