-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Module
as a replacement for HsModule
#819
Merged
mihaimaruseac
merged 45 commits into
mihaimaruseac:master
from
toku-sa-n:module-wrapper
Feb 28, 2024
Merged
Define Module
as a replacement for HsModule
#819
mihaimaruseac
merged 45 commits into
mihaimaruseac:master
from
toku-sa-n:module-wrapper
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2024
Merged
This was referenced Mar 26, 2024
Merged
This was referenced Apr 7, 2024
Merged
This was referenced May 4, 2024
Merged
This was referenced May 12, 2024
This was referenced Jun 5, 2024
Merged
Merged
Closed
Merged
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
This PR defines
Module
as a replacement forHsModule
.The purpose is to mitigate the burden caused by GHC's version changes. GHC changes the structure of its AST when it's updated, which almost always requires us to modify our pretty-printing functions, including locating CPP blocks, duplicating existing pretty-printing functions, and fixing many compile errors. Also, when we want to change the pretty-printing style, we need to modify multiple CPP blocks for just a change. By creating HIndent's own AST, we can keep up with the latest GHC with less bothersome because we only need to update our AST while we can change the printing style more easily as we don't need CPP pragmas in
Pretty
instances of our AST types.This PR is complete in the sense that it doesn't change any existing behaviors, but is incomplete because we need to replace the other AST types from GHC. Still, I chose to create multiple small PRs for easier reviewing.
Checklist