Breaking change. Update to AndroidX #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for contributing. May ask you why did you add the i18n file? It should be up to the app to implement it or not. |
|
Sorry. It was added and I forget to remove it. I will revert it this evening
сб, 26 січ. 2019, 12:34 Miguel Ruivo користувач notifications@github.com
пише:
… Hi, thank you for contributing. May ask you why did you add the i18n file?
It should be up to the app to implement it or not.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AItifQt5AdHdO4R-awkz90uLfOa-NvPwks5vHC9NgaJpZM4aUGCm>
.
|
989aedf to
9aa459b
Compare
|
@miguelpruivo Please check my MR ) I have updated my commit. So for now it should contain only stuff related to update to AndroidX. |
|
May I ask you why you found this PR useful? I mean, it's been working fine with api 27, any particular reason that made you change to 28? Thank you. |
|
All google's flutter plugins have mighated to AndroidX, so we should also
migrate to it. But I cant migrate on my own. All libs should migrate.
сб, 26 січ. 2019, 23:03 Miguel Ruivo користувач notifications@github.com
пише:
… May I ask you why you found this PR useful? I mean, it's been working fine
with api 27, any particular reason that made you change to 28?
Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AItifR-iV-4ZwlnJzWri-a9CF_bmmcLyks5vHMKpgaJpZM4aUGCm>
.
|
|
Right, but was it working fine with 27 too right? I'll take a look into it. |
|
Migration to AndroidX requires SDK version 28.
All this changes - are required, nothing done on my own)
Thanks
With Best Regards,
Vadym Pinchuk
сб, 26 січ. 2019 о 23:10 Miguel Ruivo <notifications@github.com> пише:
… Right, but was it working fine with 27 too right? I'll take a look into it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AItifeeQGHaQ35ErP7GRISXrQDODY_POks5vHMQugaJpZM4aUGCm>
.
|
miguelpruivo
requested changes
Jan 28, 2019
|
@miguelpruivo done ) |
|
Merged to |
|
@miguelpruivo thanks ) we have common cause ) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Here is I have tried to update to AndroidX. Please take a look on it. As many libs already updated. It is like a Flash mob from Google ) Cheers