Merge pull request #924 from miguelpruivo/bug/buffer-for-selected-fil…

…e-paths-too-small-on-windows #918: buffer for selected file paths too small on windows
miguelpruivo · Dec 16, 2021 · 32094fd · 32094fd
2 parents 9b75f40 + 8d19c9d
commit 32094fd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+## 4.2.8
+
+##### Desktop (Windows)
+Fixes the issue under Windows that the user could not select more than about 256 files (depending on the length of the file paths) because the buffer size for storing the selected file paths was too small. ([#918](https://github.com/miguelpruivo/flutter_file_picker/issues/918)).
+
+
 ## 4.2.7
 
 ##### Desktop (macOS & Windows)

diff --git a/lib/src/windows/file_picker_windows.dart b/lib/src/windows/file_picker_windows.dart
@@ -229,7 +229,7 @@ class FilePickerWindows extends FilePicker {
     List<String>? allowedExtensions,
     FileType type = FileType.any,
   }) {
-    final lpstrFileBufferSize = 20 * maximumPathLength;
+    final lpstrFileBufferSize = 8192 * maximumPathLength;
     final Pointer<OPENFILENAMEW> openFileNameW = calloc<OPENFILENAMEW>();
 
     openFileNameW.ref.lStructSize = sizeOf<OPENFILENAMEW>();

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -3,7 +3,7 @@ description: A package that allows you to use a native file explorer to pick sin
 homepage: https://github.com/miguelpruivo/plugins_flutter_file_picker
 repository: https://github.com/miguelpruivo/flutter_file_picker
 issue_tracker: https://github.com/miguelpruivo/flutter_file_picker/issues
-version: 4.2.7
+version: 4.2.8
 
 dependencies:
   flutter: