Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #191

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Add tests #191

merged 1 commit into from
Jun 3, 2019

Conversation

andyvesel
Copy link
Contributor

Added basic test & dependencies for UI

@andyvesel
Copy link
Contributor Author

@eriknelson do we need to concern the red travis at this point?

@eriknelson
Copy link
Contributor

@andyvesel I'm not sure if we left master in a red state for that last demo. We should start to get more strict about passing travis. I think before we merge this, we should merge 182, and then follow that with a specific PR that fixes the tests to get master back into a green state, and then we can merge this once it also is green. @ibolton336 what do you think about that?

@ibolton336
Copy link
Contributor

@andyvesel I'm not sure if we left master in a red state for that last demo. We should start to get more strict about passing travis. I think before we merge this, we should merge 182, and then follow that with a specific PR that fixes the tests to get master back into a green state, and then we can merge this once it also is green. @ibolton336 what do you think about that?

This sounds good - just realized 182 was still broken. I fixed the tests by just leaving the mock data commented out for now inside kube_store.ts. I also am hardcoding the cluster namespace list to an empty object for the time being.

@andyvesel andyvesel changed the title Add tests [WIP]Add tests May 22, 2019
@andyvesel andyvesel changed the title [WIP]Add tests Add tests May 22, 2019
@andyvesel andyvesel force-pushed the add-tests branch 4 times, most recently from c63e41e to dccb4b8 Compare May 23, 2019 16:53
cypress/fixtures/example.json Outdated Show resolved Hide resolved
cypress/integration/examples/actions.spec.js Outdated Show resolved Hide resolved
@andyvesel andyvesel force-pushed the add-tests branch 2 times, most recently from cff26d9 to f001449 Compare May 27, 2019 09:37
@andyvesel
Copy link
Contributor Author

@ibolton336 @eriknelson could you review?

cypress/plugins/index.js Outdated Show resolved Hide resolved
cypress/support/commands.js Outdated Show resolved Hide resolved
cypress/support/index.js Outdated Show resolved Hide resolved
cypress/integration/cluster_spec.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to make this run headless, and then integrate it into the travis runs.

@andyvesel andyvesel force-pushed the add-tests branch 2 times, most recently from e22cd4e to 4a33703 Compare May 29, 2019 11:41
@andyvesel
Copy link
Contributor Author

@eriknelson fyi Cypress's behaviour is to scaffold its default directories (like fixtures, plugins, etc) with every cypress run. Its been reported here cypress-io/cypress#501 or here cypress-io/cypress#619
I've disabled these files generating in cypress.json, but when it runs in headed mode on your machine, they will appear again

@andyvesel andyvesel force-pushed the add-tests branch 2 times, most recently from 487fd97 to 451c8b2 Compare May 29, 2019 12:04
@andyvesel andyvesel force-pushed the add-tests branch 8 times, most recently from 98eb12f to 6dd126c Compare May 30, 2019 14:18
@eriknelson eriknelson requested a review from a team as a code owner May 30, 2019 14:52
scripts/test-integration.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@eriknelson eriknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebases to pick up the new yarn.lock changes.

Please also add the cypress files that are created if you run it locally to the .gitignore

scripts/test-integration.sh Outdated Show resolved Hide resolved
@eriknelson eriknelson requested a review from ibolton336 May 30, 2019 20:18
@andyvesel andyvesel force-pushed the add-tests branch 2 times, most recently from 049a991 to 30ec384 Compare May 31, 2019 08:07
Copy link
Contributor

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing approval until gitignore is updated

@andyvesel andyvesel force-pushed the add-tests branch 2 times, most recently from 40cbc23 to bd2316f Compare June 3, 2019 11:08
@eriknelson eriknelson requested a review from ibolton336 June 3, 2019 13:12
cypress/integration/cluster_spec.js Outdated Show resolved Hide resolved
cypress.json Show resolved Hide resolved
@ibolton336 ibolton336 merged commit 6ea9b44 into migtools:master Jun 3, 2019
ibolton336 pushed a commit to ibolton336/mig-ui that referenced this pull request Jun 3, 2019
@andyvesel andyvesel deleted the add-tests branch June 3, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants