-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #191
Add tests #191
Conversation
@eriknelson do we need to concern the red travis at this point? |
@andyvesel I'm not sure if we left master in a red state for that last demo. We should start to get more strict about passing travis. I think before we merge this, we should merge 182, and then follow that with a specific PR that fixes the tests to get master back into a green state, and then we can merge this once it also is green. @ibolton336 what do you think about that? |
This sounds good - just realized 182 was still broken. I fixed the tests by just leaving the mock data commented out for now inside kube_store.ts. I also am hardcoding the cluster namespace list to an empty object for the time being. |
c63e41e
to
dccb4b8
Compare
cff26d9
to
f001449
Compare
@ibolton336 @eriknelson could you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to make this run headless, and then integrate it into the travis runs.
e22cd4e
to
4a33703
Compare
@eriknelson fyi Cypress's behaviour is to scaffold its default directories (like fixtures, plugins, etc) with every |
487fd97
to
451c8b2
Compare
98eb12f
to
6dd126c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebases to pick up the new yarn.lock
changes.
Please also add the cypress files that are created if you run it locally to the .gitignore
049a991
to
30ec384
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing approval until gitignore is updated
40cbc23
to
bd2316f
Compare
Added basic test & dependencies for UI