Behave the same as 1.8.4 on a new migration plan #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loading behavior was modified in 1.8.5 and the grid loading was not behaving the same as 1.8.4 when creating a new direct volume migration plan. The spinner was not covering the grid and the grid was showing the empty state. Instead revert to covering the entire grid. And only show the validating spinner when the grid selection changed. Signed-off-by: Alexander Wels <awels@redhat.com>
7c97ee6 to
6af4a32
Compare
rayfordj
pushed a commit
that referenced
this pull request
Oct 28, 2024
The loading behavior was modified in 1.8.5 and the grid loading was not behaving the same as 1.8.4 when creating a new direct volume migration plan. The spinner was not covering the grid and the grid was showing the empty state. Instead revert to covering the entire grid. And only show the validating spinner when the grid selection changed. Signed-off-by: Alexander Wels <awels@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loading behavior was modified in 1.8.5 and
the grid loading was not behaving the same as
1.8.4 when creating a new direct volume migration
plan. The spinner was not covering the grid and
the grid was showing the empty state.
Instead revert to covering the entire grid. And
only show the validating spinner when the grid
selection changed.
Show warning in plan grid if live migration is selected, but kubevirt version is not new enough or has not enabled storage live migration